Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analysis/Ast/Impl/Modules/PythonModule.cs
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ private void Parse(CancellationToken cancellationToken) {

// Do not report issues with libraries or stubs
if (sink != null) {
_diagnosticsService?.Replace(Uri, _parseErrors.Concat(Analysis.Diagnostics));
_diagnosticsService?.Replace(Uri, _parseErrors);
}

ContentState = State.Parsed;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
using Microsoft.Python.Analysis.Documents;
using Microsoft.Python.Analysis.Types;
using Microsoft.Python.Core;
using Microsoft.Python.Core.IO;
using Microsoft.Python.Core.Diagnostics;
using Microsoft.Python.Core.IO;

namespace Microsoft.Python.Analysis.Modules.Resolution {
internal sealed class MainModuleResolution : ModuleResolutionBase, IModuleManagement {
Expand Down Expand Up @@ -211,8 +211,5 @@ private bool TryCreateModuleStub(string name, string modulePath, out IPythonModu
module = !string.IsNullOrEmpty(stubPath) ? new StubPythonModule(name, stubPath, false, _services) : null;
return module != null;
}

protected override void ReportModuleNotFound(string name)
=> _log?.Log(TraceEventType.Information, $"Import not found: {name}");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,5 @@ public IPythonModule GetOrCreate(string name, ModuleResolutionBase mrb) {
}
}
}

protected abstract void ReportModuleNotFound(string name);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,5 @@ private bool IsPackage(string directory)
=> ModulePath.PythonVersionRequiresInitPyFiles(Configuration.Version) ?
!string.IsNullOrEmpty(ModulePath.GetPackageInitPy(directory)) :
_fs.DirectoryExists(directory);

protected override void ReportModuleNotFound(string name)
=> _log?.Log(TraceEventType.Verbose, $"Typeshed stub not found for '{name}'");
}
}