Skip to content

Update Poetry environment name regex to require Python version#337

Merged
karthiknadig merged 1 commit intomainfrom
unhappy-prawn
Feb 5, 2026
Merged

Update Poetry environment name regex to require Python version#337
karthiknadig merged 1 commit intomainfrom
unhappy-prawn

Conversation

@karthiknadig
Copy link
Member

Fixes #334

Refine the regex for Poetry environment names to ensure it includes the Python version, enhancing validation accuracy. Update tests to reflect this change.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (Linux) 🔺

Metric PR Baseline Delta Change
Server Startup 1ms 1ms 0ms 0%
Full Refresh 552ms 187ms 365ms 190.0%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 57.2%
Base Branch Coverage 57.2%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (Windows) ⚠️

Metric PR Baseline Delta Change
Server Startup 14ms 15ms -1ms -6.7%
Full Refresh 4201ms 742ms 3459ms 466.2%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 52.94%
Base Branch Coverage 52.94%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (macOS)

Metric PR Baseline Delta
Server Startup 1026ms 905ms 121ms
Full Refresh 56773ms 49485ms 7288ms

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig marked this pull request as ready for review February 5, 2026 15:02
@karthiknadig karthiknadig enabled auto-merge (squash) February 5, 2026 15:03
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 5, 2026
@karthiknadig karthiknadig merged commit 4dc8f73 into main Feb 5, 2026
30 checks passed
@karthiknadig karthiknadig deleted the unhappy-prawn branch February 5, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poetry: Environment name regex pattern could be more precise

2 participants