Closed
Conversation
mxschmitt
reviewed
Oct 28, 2021
| "darwin": "mac", | ||
| "linux": "linux", | ||
| "win32": "win32_x64" if sys.maxsize > 2 ** 32 else "win32", | ||
| "win32": "win32", |
Contributor
There was a problem hiding this comment.
this ends up using the wrong 32 bit variant of Node.js which is 404 when we roll. See here: https://github.com/microsoft/playwright/blob/82dd7c87ad44cd2c71358c455ba8ee7532b7ab72/utils/build/build-playwright-driver.sh#L75
| if self.all: | ||
| wheels = wheel_to_driver_map.keys() | ||
| else: | ||
| wheels = [] |
Contributor
There was a problem hiding this comment.
this seems by default not creating any wheels, we need to create the sys.platform wheels by default. For local installation and conda builds.
| shutil.copyfile(wheel_location, universal_location) | ||
| with zipfile.ZipFile(universal_location, "a") as zip: | ||
| if wheel == "macosx_11_0_universal2.whl": | ||
| # Make sure Mac wheels differ. |
Contributor
There was a problem hiding this comment.
why make sure the wheels differ?
mxschmitt
reviewed
Oct 28, 2021
| zip_file = f"driver/playwright-{driver_version}-{driver}.zip" | ||
| with zipfile.ZipFile(zip_file, "r") as zip: | ||
| extractall(zip, f"driver/{platform}") | ||
| if platform_map[sys.platform] == platform: |
Contributor
There was a problem hiding this comment.
dropping this would also break the local installations I think.
Contributor
|
See #993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.