Skip to content

feat(roll): roll Playwright 1.16.0-next-1634703014000 #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 2 commits into from
Oct 20, 2021
Merged

feat(roll): roll Playwright 1.16.0-next-1634703014000 #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc83dde
feat(roll): roll Playwright 1.16.0-next-1634703014000
mxschmitt Oct 20, 2021
aef291d
fix flaky tests
mxschmitt Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->97.0.4666.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->15.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->92.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->93.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down
3 changes: 2 additions & 1 deletion playwright/async_api/_generated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7651,7 +7651,8 @@ async def set_viewport_size(self, viewport_size: ViewportSize) -> NoneType:
`browser.new_context()` allows to set viewport size (and more) for all pages in the context at once.

`page.setViewportSize` will resize the page. A lot of websites don't expect phones to change size, so you should set the
viewport size before navigating to the page.
viewport size before navigating to the page. `page.set_viewport_size()` will also reset `screen` size, use
`browser.new_context()` with `screen` and `viewport` parameters if you need better control of these properties.

```py
page = await browser.new_page()
Expand Down
3 changes: 2 additions & 1 deletion playwright/sync_api/_generated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7466,7 +7466,8 @@ def set_viewport_size(self, viewport_size: ViewportSize) -> NoneType:
`browser.new_context()` allows to set viewport size (and more) for all pages in the context at once.

`page.setViewportSize` will resize the page. A lot of websites don't expect phones to change size, so you should set the
viewport size before navigating to the page.
viewport size before navigating to the page. `page.set_viewport_size()` will also reset `screen` size, use
`browser.new_context()` with `screen` and `viewport` parameters if you need better control of these properties.

```py
page = browser.new_page()
Expand Down
2 changes: 2 additions & 0 deletions scripts/update_api.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@ function update_api {
update_api "playwright/sync_api/_generated.py" "scripts/generate_sync_api.py"
update_api "playwright/async_api/_generated.py" "scripts/generate_async_api.py"

playwright install

python scripts/update_versions.py
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
InWheel = None
from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand

driver_version = "1.16.0-next-1634054506000"
driver_version = "1.16.0-next-1634703014000"


def extractall(zip: zipfile.ZipFile, path: str) -> None:
Expand Down
2 changes: 1 addition & 1 deletion tests/async/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ async def test_response_server_addr(page: Page, server: Server):
async def test_response_security_details(
browser: Browser, https_server: Server, browser_name, is_win, is_linux
):
if browser_name == "webkit" and is_linux:
if (browser_name == "webkit" and is_linux) or (browser_name == "webkit" and is_win):
pytest.skip("https://github.com/microsoft/playwright/issues/6759")
page = await browser.new_page(ignore_https_errors=True)
response = await page.goto(https_server.EMPTY_PAGE)
Expand Down
2 changes: 1 addition & 1 deletion tests/sync/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_response_security_details(
is_win: bool,
is_linux: bool,
) -> None:
if browser_name == "webkit" and is_linux:
if (browser_name == "webkit" and is_linux) or (browser_name == "webkit" and is_win):
pytest.skip("https://github.com/microsoft/playwright/issues/6759")
page = browser.new_page(ignore_https_errors=True)
response = page.goto(https_server.EMPTY_PAGE)
Expand Down