Skip to content

feat(expect): add typed expectations into the page & browser context.#88

Merged
pavelfeldman merged 1 commit intomicrosoft:masterfrom
pavelfeldman:expects
Jul 24, 2020
Merged

feat(expect): add typed expectations into the page & browser context.#88
pavelfeldman merged 1 commit intomicrosoft:masterfrom
pavelfeldman:expects

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman commented Jul 24, 2020

As a driver-by, this introduces async context managers that are 100% aligned with the sync ones.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 24, 2020

Pull Request Test Coverage Report for Build 180777892

  • 84 of 113 (74.34%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 84.471%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/browser_context.py 4 5 80.0%
playwright/page.py 16 23 69.57%
playwright/sync.py 30 51 58.82%
Totals Coverage Status
Change from base Build 180677180: -0.5%
Covered Lines: 2339
Relevant Lines: 2769

💛 - Coveralls

@pavelfeldman pavelfeldman changed the title feat(expect): add types expectations into the page & browser context. feat(expect): add typed expectations into the page & browser context. Jul 24, 2020
Copy link
Copy Markdown
Contributor

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@pavelfeldman pavelfeldman merged commit 03babe9 into microsoft:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants