Skip to content

test: unskip tests #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelfeldman merged 1 commit into from
Aug 8, 2021
Merged

test: unskip tests #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions tests/async/test_browsercontext_storage_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,8 @@
import asyncio
import json

import pytest


async def test_should_capture_local_storage(context, is_webkit, is_win):
if is_webkit and is_win:
pytest.skip()
page1 = await context.new_page()
await page1.route(
"**/*", lambda route: asyncio.create_task(route.fulfill(body="<html></html>"))
Expand All @@ -44,8 +40,6 @@ async def test_should_capture_local_storage(context, is_webkit, is_win):


async def test_should_set_local_storage(browser, is_webkit, is_win):
if is_webkit and is_win:
pytest.skip()
context = await browser.new_context(
storage_state={
"origins": [
Expand Down
5 changes: 3 additions & 2 deletions tests/async/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ def handle(request):
assert cast(Response, response).request.headers == server_headers


# TODO: update once fixed https://github.com/microsoft/playwright/issues/6690
@pytest.mark.xfail
async def test_request_headers_should_get_the_same_headers_as_the_server_cors(
page: Page, server, is_webkit, is_win
):
Expand Down Expand Up @@ -562,11 +564,10 @@ async def test_network_events_should_support_redirects(page, server):


async def test_request_is_navigation_request_should_work(page, server):
pytest.skip(msg="test")
requests = {}

def handle_request(request):
requests[request.url().split("/").pop()] = request
requests[request.url.split("/").pop()] = request

page.on("request", handle_request)
server.set_redirect("/rrredirect", "/frames/one-frame.html")
Expand Down
6 changes: 0 additions & 6 deletions tests/sync/test_browsercontext_storage_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,8 @@

import json

import pytest


def test_should_capture_local_storage(context, is_webkit, is_win):
if is_webkit and is_win:
pytest.skip()
page1 = context.new_page()
page1.route("**/*", lambda route: route.fulfill(body="<html></html>"))
page1.goto("https://www.example.com")
Expand All @@ -41,8 +37,6 @@ def test_should_capture_local_storage(context, is_webkit, is_win):


def test_should_set_local_storage(browser, is_webkit, is_win):
if is_webkit and is_win:
pytest.skip()
context = browser.new_context(
storage_state={
"origins": [
Expand Down