Merged
Conversation
mxschmitt
commented
May 24, 2021
| return stack | ||
|
|
||
|
|
||
| def capture_call_stack() -> List[Dict]: |
mxschmitt
commented
May 24, 2021
| browser_server = await browser_type.launch( | ||
| **launch_arguments, args=[f"--remote-debugging-port={port}"] | ||
| ) | ||
| wait_for_port(port) |
Contributor
Author
There was a problem hiding this comment.
We upstream wait now if the --remote-debugging-port arg is passed until the websocket server is ready.
dgozman
approved these changes
May 24, 2021
tests/async/test_tracing.py
Outdated
| page = await context.new_page() | ||
| await page.goto(server.PREFIX + "/grid.html") | ||
| await context.tracing.stop() | ||
| await page.wait_for_timeout(100) |
Contributor
There was a problem hiding this comment.
Do we have this upstream? Perhaps make it 1000?
Contributor
Author
There was a problem hiding this comment.
I tried to repro it upstream, but wasn't successful with it, will investigate further in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied:
First iteration for reducing flaky tests, will follow up with more.