chore: Kill windows subprocess using kill#711
Merged
mxschmitt merged 1 commit intomicrosoft:masterfrom May 26, 2021
kumaraditya303:kill-windows
Merged
chore: Kill windows subprocess using kill#711mxschmitt merged 1 commit intomicrosoft:masterfrom kumaraditya303:kill-windows
mxschmitt merged 1 commit intomicrosoft:masterfrom
kumaraditya303:kill-windows
Conversation
kumaraditya303
changed the title
Contributor
|
Could you add a description why this change was done or link a bug report? |
Contributor
Author
|
@mxschmitt Can you explain why we need extra handling on windows to kill subprocess, as far as I know the kill function was not there in python 2.5 but we only use python 3.7+ and was added in python 2.6 and there is no need to kill using taskkill. |
mxschmitt
approved these changes
May 26, 2021
Contributor
mxschmitt
left a comment
mxschmitt
left a comment
There was a problem hiding this comment.
tested it and seems working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no special handling required for windows so the code was redundant and hence removed.