Skip to content

feat(pageerror): added Error.name property support #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Apr 29, 2021
Merged

feat(pageerror): added Error.name property support #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions playwright/_impl/_api_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,14 @@
# stable API.


from typing import Optional


class Error(Exception):
def __init__(self, message: str, stack: str = None) -> None:
def __init__(self, message: str) -> None:
self.message = message
self.stack = stack
self.name: Optional[str] = None
self.stack: Optional[str] = None
super().__init__(message)


Expand Down
7 changes: 4 additions & 3 deletions playwright/_impl/_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,10 @@ def parse_error(error: ErrorPayload) -> Error:
base_error_class = Error
if error.get("name") == "TimeoutError":
base_error_class = TimeoutError
return base_error_class(
cast(str, patch_error_message(error.get("message"))), error["stack"]
)
exc = base_error_class(cast(str, patch_error_message(error.get("message"))))
exc.name = error["name"]
exc.stack = error["stack"]
return exc


def patch_error_message(message: Optional[str]) -> Optional[str]:
Expand Down
18 changes: 16 additions & 2 deletions tests/async/test_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ async def test_page_error_should_fire(page, server, is_webkit):
async with page.expect_event("pageerror") as error_info:
await page.goto(server.PREFIX + "/error.html")
error = await error_info.value
assert error.name == "Error"
assert error.message == "Fancy error!"
stack = await page.evaluate("window.e.stack")
# Note that WebKit reports the stack of the 'throw' statement instead of the Error constructor call.
Expand All @@ -422,15 +423,28 @@ async def test_page_error_should_handle_object(page, is_chromium):
assert error.message == "Object" if is_chromium else "[object Object]"


@pytest.mark.skip_browser("firefox")
async def test_page_error_should_handle_window(page, is_chromium):
# Firefox just does not report this error.
async with page.expect_event("pageerror") as error_info:
await page.evaluate("() => setTimeout(() => { throw window; }, 0)")
error = await error_info.value
assert error.message == "Window" if is_chromium else "[object Window]"


async def test_page_error_should_pass_error_name_property(page):
async with page.expect_event("pageerror") as error_info:
await page.evaluate(
"""() => setTimeout(() => {
const error = new Error("my-message");
error.name = "my-name";
throw error;
}, 0)
"""
)
error = await error_info.value
assert error.message == "my-message"
assert error.name == "my-name"


expected_output = "<html><head></head><body><div>hello</div></body></html>"


Expand Down