Skip to content

chore: added headers param for BrowserType.connect#648

Merged
mxschmitt merged 2 commits intomicrosoft:masterfrom
kumaraditya303:feature/tracing
Apr 28, 2021
Merged

chore: added headers param for BrowserType.connect#648
mxschmitt merged 2 commits intomicrosoft:masterfrom
kumaraditya303:feature/tracing

Conversation

@kumaraditya303
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason of changing that? Does it fix something?

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Apr 25, 2021

Calling str and Path is redundant and in case could result in not resolve symlink as pathlib requires Path.resolve() for symlink resolving. Python has a dedicated function for it os.fspath which is more appropriate for it See docs https://docs.python.org/3/library/pathlib.html#pathlib.Path.resolve

@kumaraditya303 kumaraditya303 changed the title feat: Tracing chore: added headers param for BrowserType.connect Apr 27, 2021
@kumaraditya303 kumaraditya303 marked this pull request as ready for review April 27, 2021 10:19
@mxschmitt mxschmitt merged commit 027c1fb into microsoft:master Apr 28, 2021
@kumaraditya303 kumaraditya303 deleted the feature/tracing branch May 4, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants