Skip to content

chore: fix update api script exit on error #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Apr 20, 2021
Merged

chore: fix update api script exit on error #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,8 @@ jobs:
uses: pre-commit/action@v2.0.0
- name: Generate APIs
run: bash scripts/update_api.sh
- name: Verify API is up to date
run: |
if [[ -n $(git status -s) ]]; then
echo "ERROR: generated code differ from the current sources:"
git diff
exit 1
fi
- name: Verify generated API is up to date
run: git diff --exit-code
build:
name: Build
timeout-minutes: 30
Expand Down
1 change: 1 addition & 0 deletions scripts/update_api.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ function update_api {
echo "Regenerated APIs"
else
echo "Exited due to errors"
exit 1
fi
}

Expand Down