Skip to content

test: cleanup tests by removing print statements #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Apr 20, 2021
Merged

test: cleanup tests by removing print statements #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/async/test_browsercontext_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ async def test_should_work_with_ip_port_notion(context_factory, server):

async def test_should_authenticate(context_factory, server):
def handler(req):
print(req)
auth = req.getHeader("proxy-authorization")
if not auth:
req.setHeader(
Expand Down Expand Up @@ -102,7 +101,6 @@ def handler(req):

async def test_should_authenticate_with_empty_password(context_factory, server):
def handler(req):
print(req)
auth = req.getHeader("proxy-authorization")
if not auth:
req.setHeader(
Expand Down
19 changes: 0 additions & 19 deletions tests/async/test_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,25 +61,6 @@ async def test_browser_type_launch_should_reject_if_executable_path_is_invalid(
assert "browser was not found" in exc.value.message


@pytest.mark.skip()
async def test_browser_type_launch_server_should_return_child_process_instance(
browser_type, launch_arguments
):
browser_server = await browser_type.launchServer(**launch_arguments)
assert browser_server.pid > 0
await browser_server.close()


@pytest.mark.skip()
async def test_browser_type_launch_server_should_fire_close_event(
browser_type, launch_arguments
):
browser_server = await browser_type.launchServer(**launch_arguments)
close_event = asyncio.Future()
browser_server.on("close", lambda: close_event.set_result(None))
await asyncio.gather(close_event, browser_server.close())


async def test_browser_type_executable_path_should_work(browser_type, browser_channel):
if browser_channel:
return
Expand Down
2 changes: 0 additions & 2 deletions tests/async/test_proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ async def test_should_work_with_ip_port_notion(browser_factory, server):

async def test_should_authenticate(browser_factory, server):
def handler(req):
print(req)
auth = req.getHeader("proxy-authorization")
if not auth:
req.setHeader(
Expand Down Expand Up @@ -103,7 +102,6 @@ def handler(req):

async def test_should_authenticate_with_empty_password(browser_factory, server):
def handler(req):
print(req)
auth = req.getHeader("proxy-authorization")
if not auth:
req.setHeader(
Expand Down
1 change: 0 additions & 1 deletion tests/sync/test_element_handle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,6 @@ def test_owner_frame_for_iframe_elements(page, server, utils):
utils.attach_frame(page, "frame1", server.EMPTY_PAGE)
frame = page.main_frame
element_handle = frame.evaluate_handle('document.querySelector("#frame1")')
print(element_handle)
assert element_handle.owner_frame() == frame


Expand Down
1 change: 0 additions & 1 deletion tests/sync/test_har.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def test_should_include_content(browser, server, tmpdir):
log = data["log"]

content1 = log["entries"][0]["response"]["content"]
print(content1)
assert content1["encoding"] == "base64"
assert content1["mimeType"] == "text/html"
s = base64.b64decode(content1["text"]).decode()
Expand Down