test: re-renable CORS tests#625
Merged
mxschmitt merged 2 commits intomicrosoft:masterfrom Apr 19, 2021
Merged
Conversation
Contributor
|
@mxschmitt It seems like an upstream issue |
pavelfeldman
approved these changes
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After enabling the video test again WK+FF failed. The reason for that was a race between
context.on("page")which comes afterpage.on("video")in WK and FF. This resulted in that the options were not yet there since thepage->browserContextassociation was not yet there.Seems like the condition which was removed was a leftover from the old video channels. In upstream PW we don't have such a logic, so lets keep it in sync.
Fixes #608