feat(roll): roll to the ToT 1617207797000#606
Merged
pavelfeldman merged 1 commit intomicrosoft:masterfrom Mar 31, 2021
Merged
Conversation
yury-s
approved these changes
Mar 31, 2021
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Where are all the tests for the new API that you mentioned?
| if matcher.matches(self.url): | ||
| await self.wait_for_load_state(state=wait_until, timeout=timeout) | ||
| return | ||
| async with self.expect_navigation( |
Member
Author
There was a problem hiding this comment.
it isn't me though.
pavelfeldman
changed the title
pavelfeldman
force-pushed
the
wait_for_url
branch
from
5934a52 to
9914f6d
Compare
mxschmitt
approved these changes
Mar 31, 2021
pavelfeldman
force-pushed
the
wait_for_url
branch
from
9914f6d to
23fb410
Compare
pavelfeldman
force-pushed
the
wait_for_url
branch
from
23fb410 to
8d49ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.