Skip to content

chore: better type annotation for channels#591

Merged
aslushnikov merged 4 commits intomicrosoft:masterfrom
kumaraditya303:better-type
Mar 24, 2021
Merged

chore: better type annotation for channels#591
aslushnikov merged 4 commits intomicrosoft:masterfrom
kumaraditya303:better-type

Conversation

@kumaraditya303
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 commented Mar 22, 2021 •
edited
Loading

Untitled

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Mar 22, 2021

There are linting issues , not sure what it is

@pavelfeldman
Copy link
Copy Markdown
Member

pavelfeldman commented Mar 22, 2021

You are overwriting recent driver docs with older driver docs. You should run setup.

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Mar 23, 2021 •
edited
Loading

Done!, yet it is failing

@pavelfeldman
Copy link
Copy Markdown
Member

pavelfeldman commented Mar 23, 2021

Well, you are rewriting entire _generated.py files, there should be only channel-related changes there.

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Mar 24, 2021

Thanks @aslushnikov

@aslushnikov aslushnikov merged commit 1a4bdf7 into microsoft:master Mar 24, 2021
@kumaraditya303 kumaraditya303 deleted the better-type branch March 24, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303 @pavelfeldman @aslushnikov