Skip to content

fix: Installation from source using GitHub#537

Merged
mxschmitt merged 1 commit intomicrosoft:masterfrom
kumaraditya303:patch-6
Apr 19, 2021
Merged

fix: Installation from source using GitHub#537
mxschmitt merged 1 commit intomicrosoft:masterfrom
kumaraditya303:patch-6

Conversation

@kumaraditya303
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 commented Mar 1, 2021 •
edited
Loading

Before when building from source using Github ex:

pip install git+https://github.com/microsoft/playwright-python

It failed because multiple wheels were created, hence it failed.

Fix

Now there is a special --all flag without which only the wheel for that specific platform would be created hence pip would now work just fine.
Now for uploading to PyPI, --all flag would be used to create all the wheels and hence pip install works as expected by the end user. The necessary GitHub actions files are updated for the same for releasing and uploading to PyPI. When user install from GitHub only the driver for that platform is downloaded and hence saves network bandwidth.
Maintainers can try out the new build process with:

pip install git+https://github.com/kumaraditya303/playwright-python@patch-6

Output:

Defaulting to user installation because normal site-packages is not writeable
Collecting git+https://github.com/kumaraditya303/playwright-python@patch-6
  Cloning https://github.com/kumaraditya303/playwright-python (to revision patch-6) to /tmp/pip-req-build-eabcvu4_
Requirement already satisfied: greenlet==1.0.0 in /home/codespace/.local/lib/python3.8/site-packages/greenlet-1.0.0-py3.8-linux-x86_64.egg (from playwright==0.152.0.post93+g375ab94) (1.0.0)
Requirement already satisfied: pyee>=8.0.1 in /home/codespace/.local/lib/python3.8/site-packages/pyee-8.1.0-py3.8.egg (from playwright==0.152.0.post93+g375ab94) (8.1.0)
Requirement already satisfied: typing-extensions in /home/codespace/.local/lib/python3.8/site-packages/typing_extensions-3.7.4.3-py3.8.egg (from playwright==0.152.0.post93+g375ab94) (3.7.4.3)
Building wheels for collected packages: playwright
  Building wheel for playwright (setup.py): started
  Building wheel for playwright (setup.py): finished with status 'done'
  Created wheel for playwright: filename=playwright-0.152.0.post93+g375ab94-py3-none-manylinux1_x86_64.whl size=58565510 sha256=173a6fa5afe4a185c8a4ba12dc5cee628f6b7d18ade08535a7124c9f3da9c3df
  Stored in directory: /tmp/pip-ephem-wheel-cache-edhss70u/wheels/12/10/0c/0184077f598942b32369ac04ca050099b4aa871070692a7773
Successfully built playwright
Installing collected packages: playwright
  Attempting uninstall: playwright
    Found existing installation: playwright 0.152.0.post93+g375ab94
    Uninstalling playwright-0.152.0.post93+g375ab94:
      Successfully uninstalled playwright-0.152.0.post93+g375ab94
Successfully installed playwright-0.152.0.post93+g375ab94

@kumaraditya303 kumaraditya303 reopened this Mar 1, 2021
@kumaraditya303 kumaraditya303 reopened this Mar 2, 2021
kumaraditya303
kumaraditya303 commented Mar 4, 2021
View reviewed changes
@pavelfeldman
Copy link
Copy Markdown
Member

pavelfeldman commented Mar 22, 2021

Is there an issue this change fixes?

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Mar 23, 2021

I have described the issue is that one cannot install the project with pip with git and it fixes that issue, it useful when installing the latest package 📦 directly from repo

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Apr 16, 2021

@mxschmitt This PR was to enable users to install playwright from github repo as per my initial comment.

mxschmitt
mxschmitt approved these changes Apr 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mxschmitt mxschmitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its helpful to try out tip-of-tree releases for us and also customers when bugs got fixed and needs to be verified. Waiting for @pavelfeldman to stamp.

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Apr 16, 2021

Yup. thanks for approving, @pavelfeldman isn't active but I am okay to wait for his 🥇 @mxschmitt

@mxschmitt mxschmitt merged commit 965afa4 into microsoft:master Apr 19, 2021
@kumaraditya303 kumaraditya303 deleted the patch-6 branch April 20, 2021 03:57
@kumaraditya303 kumaraditya303 mentioned this pull request Apr 25, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

+1 more reviewer

@mxschmitt mxschmitt mxschmitt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303 @pavelfeldman @mxschmitt