fix(driver): crash with VSCode debug terminal#405
Merged
pavelfeldman merged 2 commits intomicrosoft:masterfrom Dec 29, 2020
Merged
Conversation
pavelfeldman
approved these changes
Dec 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual Studio Code sets In their JavaScript Debug Terminal the
NODE_OPTIONSenv var with debugging arguments. Butvercel/pkg- the driver can't deal with that and exists directly with a weird error message which results that the library is not working. Users either use it and will face into that and wondering what is happening or they are randomly using that terminal.It should also be applied to Java, C#, and Go but for them its probably not that a high chance that a VSCode user will this kind of special terminal (debug terminal). I used it unintentionally a few months ago if you remember, so makes probably sense to fix it in all the language providers.
Unfortunately we can't fix it on the driver side afaik.
Contains also some other smaller drive-by nits.