test: add regression test for SSE response UTF-8 encoding#3042
Open
EternalRights wants to merge 1 commit intomicrosoft:mainfrom
Open
test: add regression test for SSE response UTF-8 encoding#3042EternalRights wants to merge 1 commit intomicrosoft:mainfrom
EternalRights wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Add tests for response body encoding in SSE and route.fetch consistency.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression tests for the UTF-8 double encoding (mojibake) issue in
response.body()when handling SSE (Server-Sent Events) streaming responses.Related Issue: Closes #3023
Problem
The issue reported that
response.body()returned double-encoded UTF-8 bytes (mojibake) for SSE streaming responses, whileroute.fetch()worked correctly. This blocked testing of real-world scenarios like:Solution
This PR adds two regression tests to prevent future regressions:
Test 1:
test_response_body_should_return_correct_utf8_bytes_for_sse_streamVerifies
response.body()returns correct raw UTF-8 bytes for SSE responses with Chinese characters and emoji, ensuring no double-encoding.Key assertions:
Test 2:
test_response_body_utf8_vs_route_fetch_consistencyEnsures
response.body()androute.fetch()return identical bytes for the same response, validating cross-API consistency.Key assertions:
Test Verification
Checklist
time.sleep()(uses auto-waiting)