chore: remove api.json and use it from driver#288
Merged
yury-s merged 1 commit intomicrosoft:masterfrom Nov 12, 2020
Merged
Conversation
mxschmitt
force-pushed
the
enh/remove-api-json
branch
from
df2c53d to
bd5d4fb
Compare
mxschmitt
force-pushed
the
enh/remove-api-json
branch
from
bd5d4fb to
fb83059
Compare
yury-s
reviewed
Nov 12, 2020
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Now that api.json is not stored in the repo there is no way to tell what version of playwright was used to generated python APIs. Let's include playwright-cli version into *_apy.py when generating APIs?
Contributor
Author
On the bots (GitHub Actions) we ensure that the generated script output is equal with the HEAD, so you can never make changes and forget to generate. By that we always know that the previous HEAD sync/async generated output was the generated with the version of the HEAD, in my mind its fine, or wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #278