fix: update api generator to support new api.json format#275
Merged
yury-s merged 8 commits intomicrosoft:masterfrom Nov 3, 2020
Merged
fix: update api generator to support new api.json format#275yury-s merged 8 commits intomicrosoft:masterfrom
yury-s merged 8 commits intomicrosoft:masterfrom
Conversation
Contributor
|
Unrelated to this PR, but wouldn't it make sense to use the api.json from the playwright-cli (spawn as subprocess with specific CLI flag, already there) instead of storing it inside the Git repository? I can follow up with this change if you think @pavelfeldman it makes sense. |
Member
Author
I think it would, it's always possible to restore api.json for given a version of cli so there is no much sense in storing another copy of it. |
pavelfeldman
approved these changes
Nov 3, 2020
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.