Skip to content

test: don't restart browser for every sync test #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelfeldman merged 1 commit into from
Oct 31, 2020
Merged

test: don't restart browser for every sync test #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,19 +60,19 @@ jobs:
run: python build_package.py
- name: Install
run: python -m playwright install
- name: Test
- name: Test Sync API
if: matrix.os != 'ubuntu-latest'
run: pytest -vv --browser=${{ matrix.browser }} --junitxml=junit/test-results-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.browser }}.xml --timeout 90
- name: Test
run: pytest -vv tests/sync --browser=${{ matrix.browser }} --timeout 90
- name: Test Sync API
if: matrix.os == 'ubuntu-latest'
run: xvfb-run pytest -vv --browser=${{ matrix.browser }} --junitxml=junit/test-results-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.browser }}.xml --timeout 90
- name: Upload pytest test results
uses: actions/upload-artifact@v1
with:
name: pytest-results-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.browser }}.xml
path: junit/test-results-${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.browser }}.xml
# Use always() to always run this step to publish test results when there are test failures
if: ${{ always() }}
run: xvfb-run pytest -vv tests/sync --browser=${{ matrix.browser }} --timeout 90
- name: Test Async API
if: matrix.os != 'ubuntu-latest'
run: pytest -vv tests/async --browser=${{ matrix.browser }} --timeout 90
- name: Test Async API
if: matrix.os == 'ubuntu-latest'
run: xvfb-run pytest -vv tests/async --browser=${{ matrix.browser }} --timeout 90

test-package-installations:
name: Test package installations
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions tests/sync/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@
from playwright import sync_playwright


@pytest.fixture
@pytest.fixture(scope="session")
def playwright():
with sync_playwright() as p:
yield p


@pytest.fixture
@pytest.fixture(scope="session")
def browser(playwright, browser_name, launch_arguments):
browser_type = None
if browser_name == "chromium":
Expand Down
10 changes: 4 additions & 6 deletions tests/sync/test_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,10 @@ def test_sync_workers_page_workers(page: Page, server):


def test_sync_playwright_multiple_times():
with sync_playwright() as pw1:
assert pw1.chromium
with pytest.raises(Error) as exc:
with sync_playwright() as pw2:
assert pw1.chromium == pw2.chromium
assert "Can only run one Playwright at a time." in exc.value.message
with pytest.raises(Error) as exc:
with sync_playwright() as pw:
assert pw.chromium
assert "Can only run one Playwright at a time." in exc.value.message


def test_sync_set_default_timeout(page):
Expand Down