chore: do not continue with no_reply messages#1905
Merged
Conversation
pavelfeldman
reviewed
May 9, 2023
| callback = self._callbacks.pop(id) | ||
| if callback.future.cancelled(): | ||
| return | ||
| if callback.no_reply: |
Member
There was a problem hiding this comment.
What was bad about calling set_result on the callback future?
Contributor
Author
There was a problem hiding this comment.
See the PR description, that we received an error (waitForEventInfo after), were setting it on the protocol callback but never awaiting it, hence it was showing the warning in the console.
Member
There was a problem hiding this comment.
I'd do a), but b) also works. Please add a comment about it when you are assining no_reply to True
pavelfeldman
approved these changes
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1903
Tricky to test that a warning does not get displayed. Before the following:
resulted in:
because the "after"
"waitForEventInfo"call was returning an exception and in Python you need to await all the exceptions.Ways thought about fixing it:
a) never add it to the self._callbacks
b) add a special no_reply flag to the callbacks - did this for now.