Skip to content

fix: wait_for_function with polling interval#1586

Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:fix-wait-for-function
Oct 10, 2022
Merged

fix: wait_for_function with polling interval#1586
mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt:fix-wait-for-function

Conversation

@mxschmitt
Copy link
Copy Markdown
Contributor

Fixes #1584

@mxschmitt mxschmitt merged commit a54664a into microsoft:main Oct 10, 2022
@johnhawkinson
Copy link
Copy Markdown

I must admit I'm a little confused; initially I thought that this parameter checking occurred in the playwright driver, but I see now I was looking at the Javascript client (playwright-core/src/client/frame.ts) rather than the driver server (playwright-core/src/server/frames.ts?). If that's even the right terminology.

It's a bit disconcerting to realize there does not seem to be any mechanism, generally speaking, to ensure that parameters are consistently handled across different frontends. It suggests to me there ought to be some kind of automated testing framework that generates parameters from a spec (maybe being the server spec or the javascript frontend?) and validates that all those parameters exist in all of the frontends. Sounds like a huge task, maybe impractical, I dunno.

Anyhow, thank you for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] wait_for_function() ignores polling parameter

3 participants