chore: roll to Playwright 1.26.0-beta-1663620933000#1555
Merged
rwoll merged 4 commits intomicrosoft:mainfrom Sep 20, 2022
Merged
chore: roll to Playwright 1.26.0-beta-1663620933000#1555rwoll merged 4 commits intomicrosoft:mainfrom
rwoll merged 4 commits intomicrosoft:mainfrom
Conversation
rwoll
commented
Sep 19, 2022
|
|
||
| async def to_be_editable( | ||
| self, | ||
| editable: bool = None, |
Member
Author
There was a problem hiding this comment.
Idiomatically, this should be:
Suggested change
| editable: bool = None, | |
| editable: bool = True, |
but the our generation/rolling will yell with:
Parameter type mismatch in LocatorAssertions.to_be_enabled(enabled=): documented as Union[bool, None], code has bool
Unless others feel strongly, this will be left as is. (Slightly non-idiomatic Python.)
rwoll
commented
Sep 20, 2022
rwoll
commented
Sep 20, 2022
mxschmitt
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports: