Skip to content

pre-commit version upgrades #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwoll merged 2 commits into from
Aug 10, 2022
+18 −3
Merged

pre-commit version upgrades #1483

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b46a6d
bump `pre-commit` versions; fix `mpy` complaints in `_sync_base.py`
symonk Aug 7, 2022
c5d85f3
Update .pre-commit-config.yaml
mxschmitt Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions playwright/_impl/_sync_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,19 @@
import inspect
import traceback
from types import TracebackType
from typing import Any, Awaitable, Callable, Dict, Generic, List, Type, TypeVar, cast
from typing import (
Any,
Callable,
Coroutine,
Dict,
Generator,
Generic,
List,
Type,
TypeVar,
Union,
cast,
)

import greenlet

Expand Down Expand Up @@ -75,10 +87,13 @@ def __init__(self, impl_obj: Any) -> None:
def __str__(self) -> str:
return self._impl_obj.__str__()

def _sync(self, coro: Awaitable) -> Any:
def _sync(
self,
coro: Union[Coroutine[Any, Any, Any], Generator[Any, Any, Any]],
) -> Any:
__tracebackhide__ = True
g_self = greenlet.getcurrent()
task = self._loop.create_task(coro)
task: asyncio.tasks.Task[Any] = self._loop.create_task(coro)
setattr(task, "__pw_stack__", inspect.stack())
setattr(task, "__pw_stack_trace__", traceback.extract_stack())

Expand Down