Skip to content

feat(cdp): expose cdp session#133

Merged
pavelfeldman merged 1 commit intomicrosoft:masterfrom
pavelfeldman:cdp
Aug 3, 2020
Merged

feat(cdp): expose cdp session#133
pavelfeldman merged 1 commit intomicrosoft:masterfrom
pavelfeldman:cdp

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman commented Aug 3, 2020

  • driver-by: all optional arguments in the API should be = None, not = defaultValue.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 192702471

  • 105 of 119 (88.24%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 88.646%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/object_factory.py 12 13 92.31%
playwright/selectors.py 6 7 85.71%
playwright/async_api.py 19 21 90.48%
playwright/chromium_browser_context.py 23 27 85.19%
playwright/sync_api.py 15 21 71.43%
Totals Coverage Status
Change from base Build 192672313: 0.003%
Covered Lines: 3482
Relevant Lines: 3928
💛 - Coveralls

@pavelfeldman pavelfeldman merged commit 359f8cc into microsoft:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelfeldman @coveralls