chore: added Docker image publishing#1171
Conversation
mxschmitt
force-pushed
the
docker-publishing
branch
5 times, most recently
from
e33e596 to
01eade4
Compare
mxschmitt
force-pushed
the
docker-publishing
branch
from
01eade4 to
66a9bdb
Compare
| cd "$(dirname "$0")" | ||
|
|
||
| MCR_IMAGE_NAME="playwright-python" | ||
| PW_VERSION=$(python -c "from playwright._repo_version import version;print(version)") |
There was a problem hiding this comment.
Where does "playwright" come from? Do I need to be inside some venv for this to work? If so, sounds fragile! Any chance we can extract version to a separate file and just cat it here?
There was a problem hiding this comment.
Does not depend on venv. We install it globally on gha which is common practise.
|
|
||
| publish_docker_images_with_arch_suffix focal amd64 | ||
| publish_docker_images_with_arch_suffix focal arm64 | ||
| publish_docker_manifest focal amd64 arm64 |
There was a problem hiding this comment.
I see you don't publish bionic. Do we have a strong signal that we can do so? I'd keep it for now to minimize disturbance of our clients.
There was a problem hiding this comment.
I’d drop bionic anyway in 2 months when ubuntu 22 ltd comes out.
| # Install Python | ||
| apt-get install -y python3 python3-distutils curl && \ | ||
| update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \ | ||
| curl -sSL https://bootstrap.pypa.io/get-pip.py -o get-pip.py && \ |
There was a problem hiding this comment.
why different lines here?
We currently do the following:
https://github.com/microsoft/playwright/blob/a6fecb5d4b273c934069781c65ae5d50a5007a38/utils/docker/Dockerfile.focal#L16-L20
There was a problem hiding this comment.
The apt pip is very very old and does not work with our arm afaik.
mxschmitt
force-pushed
the
docker-publishing
branch
from
66a9bdb to
52a66e3
Compare
2 participants
#1130