chore: roll Playwright to 1.18.0-beta-1642508722000#1111
Merged
mxschmitt merged 1 commit intomicrosoft:mainfrom Jan 18, 2022
Merged
chore: roll Playwright to 1.18.0-beta-1642508722000#1111mxschmitt merged 1 commit intomicrosoft:mainfrom
mxschmitt merged 1 commit intomicrosoft:mainfrom
Conversation
mxschmitt
force-pushed
the
roll/1.18.0-beta-1642508722000
branch
from
235d4a8 to
807ed42
Compare
pavelfeldman
approved these changes
Jan 18, 2022
| asyncio.create_task(continue_route()) | ||
|
|
||
| async def _race_with_page_close(self, future: Coroutine) -> None: | ||
| if hasattr(self.request.frame, "_page"): |
Contributor
Author
There was a problem hiding this comment.
Some dialog frame tests don't have a page super early on attached, we check it upstream too and the tests were failing otherwise.
mxschmitt
force-pushed
the
roll/1.18.0-beta-1642508722000
branch
from
807ed42 to
6e84e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1094
Fixes #1008