Skip to content

test: have server.set_auth accepting strings #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschmitt merged 1 commit into from
Nov 9, 2021
Merged

test: have server.set_auth accepting strings #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/async/test_browsercontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,14 +535,14 @@ async def test_route_should_fall_back_to_context_route(context, server):


async def test_auth_should_fail_without_credentials(context, server):
server.set_auth("/empty.html", b"user", b"pass")
server.set_auth("/empty.html", "user", "pass")
page = await context.new_page()
response = await page.goto(server.EMPTY_PAGE)
assert response.status == 401


async def test_auth_should_work_with_correct_credentials(browser, server):
server.set_auth("/empty.html", b"user", b"pass")
server.set_auth("/empty.html", "user", "pass")
context = await browser.new_context(
http_credentials={"username": "user", "password": "pass"}
)
Expand All @@ -553,7 +553,7 @@ async def test_auth_should_work_with_correct_credentials(browser, server):


async def test_auth_should_fail_with_wrong_credentials(browser, server):
server.set_auth("/empty.html", b"user", b"pass")
server.set_auth("/empty.html", "user", "pass")
context = await browser.new_context(
http_credentials={"username": "foo", "password": "bar"}
)
Expand All @@ -564,7 +564,7 @@ async def test_auth_should_fail_with_wrong_credentials(browser, server):


async def test_auth_should_return_resource_body(browser, server):
server.set_auth("/playground.html", b"user", b"pass")
server.set_auth("/playground.html", "user", "pass")
context = await browser.new_context(
http_credentials={"username": "user", "password": "pass"}
)
Expand Down
2 changes: 1 addition & 1 deletion tests/async/test_defaultbrowsercontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ async def test_should_support_http_credentials_option(server, launch_persistent)
(page, context) = await launch_persistent(
http_credentials={"username": "user", "password": "pass"}
)
server.set_auth("/playground.html", b"user", b"pass")
server.set_auth("/playground.html", "user", "pass")
response = await page.goto(server.PREFIX + "/playground.html")
assert response.status == 200

Expand Down
2 changes: 1 addition & 1 deletion tests/async/test_popup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ async def test_should_inherit_offline_from_browser_context(context, server):
async def test_should_inherit_http_credentials_from_browser_context(
browser: Browser, server
):
server.set_auth("/title.html", b"user", b"pass")
server.set_auth("/title.html", "user", "pass")
context = await browser.new_context(
http_credentials={"username": "user", "password": "pass"}
)
Expand Down
4 changes: 2 additions & 2 deletions tests/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ def process(self) -> None:
creds_correct = False
if authorization_header:
creds_correct = auth.get(path) == (
request.getUser(),
request.getPassword(),
request.getUser().decode(),
request.getPassword().decode(),
)
if not creds_correct:
request.setHeader(
Expand Down