Thanks for working on playwright, it's much needed for automated tests!

I personally think that I would rather have browsers installed during the pip install step even if it didn't have progress bars.

I looked around for a way to automatically install browsers on first test run perhaps and it looks like you would have to modify sys.argv to use the existing main() install.

playwright-python/playwright/main.py

Lines 123 to 133 in fc5485c

    
           def main() -> None: 
        
               if "install" not in sys.argv: 
        
                   print('Run "python -m playwright install" to complete installation') 
        
                   return 
        
               package_path = get_file_dirname() 
        
               driver_name = compute_driver_name() 
        
               driver_executable = package_path / "drivers" / driver_name 
        
               print("Installing the browsers...") 
        
               subprocess.check_call(f"{driver_executable} install", shell=True) 
        
               print("Playwright is now ready for use")

Could the install function perhaps be extracted this into a separate function that can be called without modifying sys.argv?

	def main() -> None:
	if "install" not in sys.argv:
	print('Run "python -m playwright install" to complete installation')
	return
	package_path = get_file_dirname()
	driver_name = compute_driver_name()
	driver_executable = package_path / "drivers" / driver_name
	print("Installing the browsers...")
	subprocess.check_call(f"{driver_executable} install", shell=True)

	print("Playwright is now ready for use")

Install browsers upon pip install, not the first launch #21

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions