fix: pass required env variables for new driver#774
Merged
aslushnikov merged 2 commits intomicrosoft:mainfrom Jan 19, 2022
Merged
fix: pass required env variables for new driver#774aslushnikov merged 2 commits intomicrosoft:mainfrom
aslushnikov merged 2 commits intomicrosoft:mainfrom
Conversation
yury-s
reviewed
Jan 15, 2022
playwright/src/main/java/com/microsoft/playwright/impl/Utils.java
Outdated
Show resolved
Hide resolved
aslushnikov
force-pushed
the
pass-env-everywhere
branch
from
dadd34c to
8df99b7
Compare
yury-s
approved these changes
Jan 15, 2022
| APIResponse response = request.get(server.EMPTY_PAGE); | ||
| assertTrue(response.ok()); | ||
| assertEquals(server.EMPTY_PAGE, response.url()); | ||
| assertTrue(serverRequest.get().headers.get("user-agent").get(0).contains("java")); |
|
|
||
| public static void setRequiredEnvironmentVariables(ProcessBuilder pb) { | ||
| if (!pb.environment().containsKey("PW_CLI_TARGET_LANG")) { | ||
| pb.environment().put("PW_CLI_TARGET_LANG", "java"); |
Member
There was a problem hiding this comment.
looks like PW_CLI_TARGET_LANG /PW_CLI_TARGET_LANG_VERSION are used beyond just codegen, let's rename them (in separate pr) to PW_LANG / PW_LANG_VERSION before it's too late?
Contributor
Author
There was a problem hiding this comment.
Let's do this in a follow-up and on tip-of-tree only.
I filed an issue for myself regarding this: microsoft/playwright#11450
yury-s
approved these changes
Jan 18, 2022
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Looks good, the test is failing though
aslushnikov
force-pushed
the
pass-env-everywhere
branch
from
b62b3ff to
17c1aa5
Compare
aslushnikov
force-pushed
the
pass-env-everywhere
branch
from
17c1aa5 to
0e2abf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #772