Skip to content

Optimize parseLiteral for number-heavy JSON files (ala GeoJSON) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeschli merged 2 commits into from
Sep 16, 2020
Merged

Optimize parseLiteral for number-heavy JSON files (ala GeoJSON) #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0eaf189
optimize parseLiteral for number-heavy JSON files (ala GeoJSON)
mbullington Jun 9, 2020
7505449
switch from parseFloat to Number
mbullington Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/impl/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,16 +482,14 @@ export function visit(text: string, visitor: JSONVisitor, options: ParseOptions
function parseLiteral(): boolean {
switch (_scanner.getToken()) {
case SyntaxKind.NumericLiteral:
let value = 0;
try {
value = JSON.parse(_scanner.getTokenValue());
if (typeof value !== 'number') {
handleError(ParseErrorCode.InvalidNumberFormat);
value = 0;
}
} catch (e) {
const tokenValue = _scanner.getTokenValue();
let value = Number(tokenValue);

if (isNaN(value)) {
handleError(ParseErrorCode.InvalidNumberFormat);
value = 0;
}

onLiteralValue(value);
break;
case SyntaxKind.NullKeyword:
Expand Down