Preserve inline property comments during JSONC edits - #133
Open
RKS (rksharma-owg) wants to merge 1 commit into
Open
RKS (rksharma-owg) wants to merge 1 commit into
RKS (rksharma-owg) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appending a property with
modify()can move the previous property's inline comment onto the new property. Deleting a property can drop the previous property's comment and leave the deleted property's comment attached to its neighbor.The edit boundaries were based on AST value offsets, which exclude comments. Scan same-line trailing trivia with the existing JSONC scanner so edits preserve the preceding property's comments, remove the deleted property's trailing comments, and place commas correctly. Standalone comments after the line boundary retain the existing behavior.
Validation on Node 22.23.1, macOS arm64:
npm testpassed compilation, ESLint and 87 tests.npm test: compilation, ESLint and 117 tests passed.git diff --checkpasses.No new dependency or public API change. This patch is limited to object-property edits. The Windows/Linux CI matrix has not run for this local branch; no performance improvement is claimed.
Fixes #125.
Prepared with Codex assistance; the checks above ran locally.