Repository navigation
Fix(playground): restore styles in web-component sample - #5497
Open
Srinivas Rao Tammireddy (srinu2003) wants to merge 2 commits into
Open
Srinivas Rao Tammireddy (srinu2003) wants to merge 2 commits into
Srinivas Rao Tammireddy (srinu2003) wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
creating-the-editor/web-componentplayground sample which broke in Monaco >= v0.53.0.Cause
In Monaco v0.53.0+, stylesheet injection no longer adds the
data-name="vs/editor/editor.main"attribute to the<link>element. As a result,document.querySelectorAll("link[rel='stylesheet'][data-name^='vs/']")returns an empty NodeList, leaving the shadow root unstyled.Fix
Added
[href*='vs/']to the selector:This maintains backward compatibility with older versions (which use
data-name) while working with all current versions where styles are matched by path.