RFC: Relax aligned_alloc() restrictions #584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Passing a size which is not an integral multiple of alignment" is too
strict, and lots of code relies on it, i.e.:
(gdb) bt
0 mi_aligned_alloc (alignment=8, size=44) at alloc-posix.c:88
1 0x000000002dc55fdd in aligned_alloc (alignment=8, size=44) at alloc-override.c:251
2 0x0000000017be85b6 in Memory::newImpl<std::align_val_t> (size=44, align=(unknown: 8)) at memory.h:47
3 operator new (size=44, align=(unknown: 8)) at new_delete.cpp:60
4 0x000000002ba66c5d in llvm::allocate_buffer(unsigned long, unsigned long) ()
5 0x000000002898eba1 in llvm::MallocAllocator::Allocate(unsigned long, unsigned long) ()
6 0x000000002b9e95ee in llvm::StringMapEntry<llvm::cl::Option*>* llvm::StringMapEntry<llvm::cl::Option*>::Create<llvm::MallocAllocator, llvm::cl::Option*>(llvm::StringRef, llvm::MallocAllocator&, llvm::cl::Option*&&) ()
7 0x000000002b9e9428 in std::__1::pair<llvm::StringMapIterator<llvm::cl::Option*>, bool> llvm::StringMap<llvm::cl::Option*, llvm::MallocAllocator>::try_emplace<llvm::cl::Option*>(llvm::StringRef, llvm::cl::Option*&&) ()
8 0x000000002b9e925f in llvm::StringMap<llvm::cl::Option*, llvm::MallocAllocator>::insert(std::__1::pair<llvm::StringRef, llvm::cl::Option*>) ()
9 0x000000002b9dc689 in (anonymous namespace)::CommandLineParser::addOption(llvm::cl::Option*, llvm::cl::SubCommand*) ()
10 0x000000002b9cf219 in (anonymous namespace)::CommandLineParser::addOption(llvm::cl::Option*, bool) ()
11 0x000000002b9ce831 in llvm::cl::Option::addArgument() ()
daanx
added a commit
that referenced
this pull request
Oct 31, 2022
… in 'alloc_aligned' as too many programs need this; see PR #584
Collaborator
|
Thanks for the PR! and apologies for the late merge -- I fixed this directly with a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Passing a size which is not an integral multiple of alignment" is too
strict, and lots of code relies on it, i.e.: