fix build on non desktop windows app partitions #1084
Closed
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daanx
added a commit
that referenced
this pull request
Jun 8, 2025
Collaborator
|
Thank you so much for the upstream from CPython -- highly appreciated. I merged this manually where I avoid the use of |
Author
|
Yes your patch works as expected 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch set I used to build mimalloc on the xbox to get Cpython to build there.
The following functions / types are unavailable:
NTSTATUSnot availableGetConsoleScreenBufferInfo,CONSOLE_SCREEN_BUFFER_INFOandWriteConsoleAunavailableGetNumaNodeProcessorMaskunavailableGetLargePageMinimumunavailableThe functions for
GetPhysicallyInstalledSystemMemoryaren't available either, but they aren't used in the mimalloc version in Cpython 3.13. Since they are dynamically loaded it's quite likely that they won't cause any problems.I wasn't entirely sure how you would like to have the api family guards defined / used in there.