Repository navigation
fix(docx): keep raw LaTeX in math spans instead of Markdown escapes - #2760
Open
Yunare Maia (yunaremaia) wants to merge 1 commit into
Open
Yunare Maia (yunaremaia) wants to merge 1 commit into
Yunare Maia (yunaremaia) wants to merge 1 commit into
Conversation
oMath equations are injected as $...$ text, so the HTML-to-Markdown step escapes LaTeX _ and * as \_ and \*, breaking the math. Unescape those two sequences inside math spans only; typed text keeps escapes. Closes microsoft#2744.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2744. oMath equations are injected as$...$ text runs, so the HTML-to-Markdown step escapes LaTeX _ and * (output: $\sum\_...$ ). _unescape_math_spans restores the raw LaTeX inside math spans only; typed text elsewhere keeps its escapes. TDD: new test_docx_math_no_markdown_escapes built from the issue's reproducer failed before, passes after; full tests/test_docx.py 102 passed. Implemented and reviewed by hand.