add user settings #94
Conversation
|
|
||
| public static String CONFIG_LOG_LEVEL = "vscode.java.configLogLevel"; | ||
|
|
||
| public static String UPDATE_USER_SETTINGS = "vscode.java.updateUserSettings"; |
There was a problem hiding this comment.
We need to not confuse the user by providing the command vscode.java.updateUserSetting. It's actually debugger settings. So suggest making it "vscode.java.updateDebuggerSettings".
| public class StringObjectFormatter extends ObjectFormatter implements IValueFormatter { | ||
| public static final String MAX_STRING_LENGTH_OPTION = "max_string_length"; | ||
| private static final int DEFAULT_MAX_STRING_LENGTH = 100; | ||
| private static final int DEFAULT_MAX_STRING_LENGTH = 200; |
There was a problem hiding this comment.
Can I understand why 100 -> 200?
There was a problem hiding this comment.
the default length is the length most users saw, the 100 is too small for normal cases like connections string, path, I would advise to use 256.
| if (showFullyQualifiedNames) { | ||
| options.put(SimpleTypeFormatter.QUALIFIED_CLASS_NAME_OPTION, showFullyQualifiedNames); | ||
| } | ||
| VariableUtils.applyFormatterOptions(options, evalArguments.format != null && evalArguments.format.hex, |
There was a problem hiding this comment.
Do we need to apply the formatter options every time a evaluate request is processed? If the options stay inside VadiableUtils, then we can call it when a user actually changes the settings.
There was a problem hiding this comment.
The condition for generating options is also influenced by argument, not only user settings.
| if (showFullyQualifiedNames) { | ||
| options.put(SimpleTypeFormatter.QUALIFIED_CLASS_NAME_OPTION, showFullyQualifiedNames); | ||
| } | ||
| VariableUtils.applyFormatterOptions(options, varArgs.format != null && varArgs.format.hex, false); |
There was a problem hiding this comment.
Same here, do we really need to apply settings during processing a request?
…va-debug into andy_user_settings2
| Object valueObj = map.get(keyStr); | ||
| try { | ||
| switch (keyStr) { | ||
| case "show_hex": |
There was a problem hiding this comment.
Not consistent with the key on vscode user settings.
|
|
||
| public final class UserSettings { | ||
| private static final Logger logger = Logger.getLogger(Configuration.LOGGER_NAME); | ||
| public static int maxStringLength = 0; |
There was a problem hiding this comment.
Not sure if it is a good idea to expose the (static) fields directly.
No description provided.