Support HCR for gradle build server projects #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
commented
Jun 3, 2024
...lugin/src/main/java/com/microsoft/java/debug/plugin/internal/JavaHotCodeReplaceProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <sheche@microsoft.com>
...rosoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/Compile.java
Outdated
Show resolved
Hide resolved
| */ | ||
| public static IProject getMainProject(String mainProjectName, String mainClassName) { | ||
| IProject mainProject = null; | ||
| if (StringUtils.isNotEmpty(mainProjectName)) { |
Contributor
There was a problem hiding this comment.
use isNotBlank instead
testforstephen
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle build server project, if yes, trigger the incremental build.
requires: microsoft/vscode-gradle#1493
How to test the change
replace the following jar file into the vscode gradle extension installation path, under the
serverfoldercom.microsoft.gradle.bs.importer-0.2.0.jar.zip
Launch debugger extension with this change.
fix microsoft/vscode-gradle#1449
fix redhat-developer/vscode-java#3392
fix microsoft/vscode-java-debug#1402
fix microsoft/vscode-java-debug#1481
fix #554