Skip to content

Be able to search lambda breakpoint for both chained and multiline lambdas #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
testforstephen wants to merge 2 commits into from
Closed

Be able to search lambda breakpoint for both chained and multiline lambdas #529

testforstephen wants to merge 2 commits into from

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Dec 11, 2023

testforstephen
testforstephen commented Dec 11, 2023
View reviewed changes
...g.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/JdtSourceLookUpProvider.java
// location.
BreakpointLocationLocator locator = new BreakpointLocationLocator(astUnit,
sourceLine, true, true);
sourceLine, true, true, astUnit.getPosition(sourceLine, 0), 0);
Copy link
Contributor Author

@testforstephen testforstephen Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a limitation of the upstream ValidBreakpointLocationLocator. It requires the selection offset to search for line breakpoints on nested chained or multiline lambdas.

Copy link
Contributor Author

@testforstephen testforstephen Dec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the JDT PR eclipse-jdt/eclipse.jdt.debug@5155869#diff-cc2898c3d3963bc7a2093c82575beee0b8b6b3cbf3bd36f38dc46a32d56fb322 for lambda breakpoint support.

@testforstephen
Copy link
Contributor Author

testforstephen commented Dec 13, 2023

superseded by #522

@testforstephen testforstephen deleted the jinbo_lambda branch December 13, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdneo jdneo Awaiting requested review from jdneo jdneo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Critical] Cannot debug multiline nested method expression's lambda statements Breakpoint with inline lambdas work only with last one

1 participant

@testforstephen