Improve inline breakpoint discovery for multi line lambda #489 - #500
Closed
Gayan Perera (gayanper) wants to merge 1 commit into
Closed
Improve inline breakpoint discovery for multi line lambda #489#500Gayan Perera (gayanper) wants to merge 1 commit into
Gayan Perera (gayanper) wants to merge 1 commit into
Conversation
Gayan Perera (gayanper)
requested review from
Sheng Chen (jdneo) and
Jinbo Wang (testforstephen)
as code owners
July 1, 2023 11:58
Contributor
Author
|
Jinbo Wang (@testforstephen) WDYT about this change, I closed the previous PR since it could cause side effects |
Gayan Perera (gayanper)
force-pushed
the
improve_lambda_location
branch
from
July 9, 2023 17:05
beb12cc to
c25879f
Compare
Gayan Perera (gayanper)
force-pushed
the
improve_lambda_location
branch
from
November 25, 2023 17:34
c25879f to
ab47c42
Compare
Contributor
Author
|
Closing this in favor of #522 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improve the discovery of inline breakpoints on lines as described in issue #489. The changes tries to keep the lambda breakpoint location computation as it is while providing the inline breakpoint location based on the formatted code.