Repository navigation
Improve ASTParser options when project is resolved. Fix #488 - #490
Merged
Jinbo Wang (testforstephen) merged 2 commits intoMay 26, 2023
Merged
Conversation
Gayan Perera (gayanper)
requested review from
Sheng Chen (jdneo) and
Jinbo Wang (testforstephen)
as code owners
May 25, 2023 17:36
Jinbo Wang (testforstephen)
previously approved these changes
May 26, 2023
Jinbo Wang (testforstephen)
left a comment
Jinbo Wang (testforstephen)
left a comment
Contributor
There was a problem hiding this comment.
LGTM. setProject will also set the project's compiler options to the paser.
Contributor
Gayan Perera (@gayanper) checkstyle failed. |
Contributor
forget it. I have submit a fix in this PR for checkstyle error. |
Jinbo Wang (testforstephen)
approved these changes
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both the project and compiler options are set, the AST parser doesn't output the method statements. But if we only set the compiler options when project is not resolved, then method statements are resolved.
The issue with #488 was that method was missing statements, and BreakpointLocator endup seeing that closest location is at the end of the method.