Repository navigation
Fixes NumericFormatter failure on systems with other decimal separator - #443
Merged
Merged
Conversation
Jinbo Wang (testforstephen)
approved these changes
Sep 13, 2022
Contributor
|
@crissNb472 thanks for contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain regions (e.g. Brazil, Germany, etc.), a comma is used instead of a dot as a decimal separator by default.
This change will set the default locale to US (so a dot is used as a decimal separator) before performing numeric formatter tests.
This PR fixes #337. Solution already addressed by Gustavo Siqueira (@siqueira-gustavo) (full credit goes to him), but no changes have been made.