Skip to content

Increase polling frequency to ensure that Java processes are detected #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
testforstephen merged 2 commits into from
May 31, 2022
Merged

Increase polling frequency to ensure that Java processes are detected #416

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0541f51
Increase polling frequency to ensure that Java processes are detected
testforstephen May 31, 2022
5cb7918
Make checkstyle happy
testforstephen May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...a.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/LaunchUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public static ProcessHandle findJavaProcessInTerminalShell(long shellPid, String
ProcessHandle shellProcess = ProcessHandle.of(shellPid).orElse(null);
if (shellProcess != null) {
int retry = 0;
final int INTERVAL = 100;
final int INTERVAL = 20/*ms*/;
final int maxRetries = timeout / INTERVAL;
final boolean isCygwinShell = isCygwinShell(shellProcess.info().command().orElse(null));
while (retry <= maxRetries) {
Expand All @@ -127,11 +127,17 @@ public static ProcessHandle findJavaProcessInTerminalShell(long shellPid, String
}).findFirst();

if (subProcessHandle.isPresent()) {
if (retry > 0) {
logger.info("Retried " + retry + " times to find Java subProcess.");
}
logger.info("shellPid: " + shellPid + ", javaPid: " + subProcessHandle.get().pid());
return subProcessHandle.get();
} else if (isCygwinShell) {
long javaPid = findJavaProcessByCygwinPsCommand(shellProcess, javaCommand);
if (javaPid > 0) {
if (retry > 0) {
logger.info("Retried " + retry + " times to find Java subProcess.");
}
logger.info("[Cygwin Shell] shellPid: " + shellPid + ", javaPid: " + javaPid);
return ProcessHandle.of(javaPid).orElse(null);
}
Expand All @@ -147,8 +153,9 @@ public static ProcessHandle findJavaProcessInTerminalShell(long shellPid, String
} catch (InterruptedException e) {
// do nothing
}
logger.info("Retry to find Java subProcess of shell pid " + shellPid);
}

logger.info("Retried " + retry + " times but failed to find Java subProcess of shell pid " + shellPid);
}

return null;
Expand Down