Make DAP implementation to be encoding-neutral #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testforstephen
commented
Nov 18, 2021
| cs = Charset.defaultCharset(); | ||
| } | ||
| String source = readFile(filePath, cs); | ||
| String source = readFile(filePath); |
Contributor
Author
There was a problem hiding this comment.
When parsing Java source files, let's keep using the same encoding as JDT language server.
jdneo
approved these changes
Nov 19, 2021
Eskibear
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires microsoft/vscode-java-debug#1077
This project is an implementation of DAP, it's better to keep encoding neutral. It's the client's responsibility to determine what encoding to use to launch user's application.