Repository navigation
Dedup the changed classes before hot reload - #345
Merged
Jinbo Wang (testforstephen) merged 2 commits intoAug 3, 2020
Merged
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Jinbo Wang (testforstephen)
requested review from
Yan Zhang (Eskibear) and
Sheng Chen (jdneo)
July 31, 2020 07:19
Yan Zhang (Eskibear)
approved these changes
Aug 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Fix microsoft/vscode-java-debug#855
Root cause:
Previously the extension uses Set to dedup the changed resources and classes. One exceptional case is for multiple module maven projects, the classes changed in sub module also appear in the resource change listener of the parent project. Use HastSet cannot dedup the resource object even though they are pointing to the same physical file.