Skip to content

Clean up the registered logger handlers when stopping the plugin #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
testforstephen merged 1 commit into from
Nov 27, 2019
Merged

Clean up the registered logger handlers when stopping the plugin #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ugin/src/main/java/com/microsoft/java/debug/plugin/internal/JavaDebuggerServerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public void start(BundleContext context) throws Exception {
@Override
public void stop(BundleContext context) throws Exception {
logger.info("Stopping " + PLUGIN_ID);
LogUtils.cleanupHandlers();
}

}
Expand Down
16 changes: 16 additions & 0 deletions ...ft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/LogUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

package com.microsoft.java.debug.plugin.internal;

import java.util.logging.Handler;
import java.util.logging.Level;
import java.util.logging.Logger;

Expand All @@ -32,6 +33,21 @@ public static void initialize(Level level) {
logger.setLevel(level);
}

/**
* Remove the logger handlers registered to the global logger.
*/
public static void cleanupHandlers() {
Handler[] handlers = logger.getHandlers();
for (Handler handler : handlers) {
logger.removeHandler(handler);
}

Handler[] usageHandlers = usageDataLogger.getHandlers();
for (Handler handler : usageHandlers) {
usageDataLogger.removeHandler(handler);
}
}

/**
* Configure log level setting for java debugger.
*
Expand Down