Skip to content

Fix bug: cannot stop the debug session automatically in attach mode #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jinbo Wang (testforstephen) merged 1 commit into from
May 20, 2019
Merged

Fix bug: cannot stop the debug session automatically in attach mode #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ...n/java/com/microsoft/java/debug/core/adapter/handler/ConfigurationDoneRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,18 @@ private void handleDebugEvent(DebugEvent debugEvent, IDebugSession debugSession,
context.setVmTerminated();
context.getProtocolServer().sendEvent(new Events.ExitedEvent(0));
} else if (event instanceof VMDisconnectEvent) {
// ignore since LaunchRequestHandler has already handled.
if (context.isAttached()) {
context.setVmTerminated();
context.getProtocolServer().sendEvent(new Events.TerminatedEvent());
// Terminate eventHub thread.
try {
debugSession.getEventHub().close();
} catch (Exception e) {
// do nothing.
}
} else {
// Skip it when the debugger is in launch mode, because LaunchRequestHandler will handle the event there.
}
} else if (event instanceof ThreadStartEvent) {
ThreadReference startThread = ((ThreadStartEvent) event).thread();
Events.ThreadEvent threadEvent = new Events.ThreadEvent("started", startThread.uniqueID());
Expand Down