Repository navigation
Add utility to check java project settings - #264
Merged
Merged
Conversation
Jinbo Wang (testforstephen)
requested review from
Andy Xu(devdiv) (andxu) and
Yaohai Zheng (yaohaizh)
April 12, 2019 04:41
| public static final String VALIDATE_LAUNCHCONFIG = "vscode.java.validateLaunchConfig"; | ||
| public static final String RESOLVE_MAINMETHOD = "vscode.java.resolveMainMethod"; | ||
| public static final String INFER_LAUNCH_COMMAND_LENGTH = "vscode.java.inferLaunchCommandLength"; | ||
| public static final String DETECT_PREVIEW_FLAG = "vscode.java.detectEnablePreviewFeaturesFlag"; |
Contributor
There was a problem hiding this comment.
I think this could be a more common API about fetch settings.
Contributor
Author
There was a problem hiding this comment.
The new API will return the java project settings map, and delay the check to the client side.
Contributor
There was a problem hiding this comment.
This line is not necessary now.
Yaohai Zheng (yaohaizh)
left a comment
Yaohai Zheng (yaohaizh)
left a comment
Contributor
There was a problem hiding this comment.
Could we provide a more generic version of API
Jinbo Wang (testforstephen)
force-pushed
the
jinbo_java12fix
branch
from
April 12, 2019 08:38
1c7de7d to
b1b0fa3
Compare
Jinbo Wang (testforstephen)
changed the title
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Jinbo Wang (testforstephen)
force-pushed
the
jinbo_java12fix
branch
from
April 15, 2019 05:15
a5a84b7 to
60034b0
Compare
Jinbo Wang (testforstephen)
changed the title
Yaohai Zheng (yaohaizh)
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
This is the utility for the PR microsoft/vscode-java-debug#561