Skip to content

Increase the timeout when attaching to integrated/external terminal #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
testforstephen merged 2 commits into from
Mar 5, 2019
Merged

Increase the timeout when attaching to integrated/external terminal #256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
301f83d
Increase the timeout when attaching to integrated/external terminal
testforstephen Feb 28, 2019
4c8bbe8
Refine the timeout error message because of long command line
testforstephen Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions .../main/java/com/microsoft/java/debug/core/adapter/handler/LaunchWithDebuggingDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
import java.util.concurrent.CompletionException;
import java.util.logging.Logger;

import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.SystemUtils;

import com.google.gson.JsonObject;
import com.microsoft.java.debug.core.Configuration;
import com.microsoft.java.debug.core.DebugException;
Expand Down Expand Up @@ -47,12 +50,13 @@
import com.sun.jdi.connect.Connector;
import com.sun.jdi.connect.IllegalConnectorArgumentsException;
import com.sun.jdi.connect.ListeningConnector;
import com.sun.jdi.connect.TransportTimeoutException;
import com.sun.jdi.connect.VMStartException;

public class LaunchWithDebuggingDelegate implements ILaunchDelegate {

protected static final Logger logger = Logger.getLogger(Configuration.LOGGER_NAME);
private static final int ACCEPT_TIMEOUT = 10 * 1000;
private static final int ATTACH_TERMINAL_TIMEOUT = 20 * 1000;
private static final String TERMINAL_TITLE = "Java Debug Console";
protected static final long RUNINTERMINAL_TIMEOUT = 10 * 1000;

Expand All @@ -67,7 +71,7 @@ public CompletableFuture<Response> launchInTerminal(LaunchArguments launchArgume
List<ListeningConnector> connectors = vmProvider.getVirtualMachineManager().listeningConnectors();
ListeningConnector listenConnector = connectors.get(0);
Map<String, Connector.Argument> args = listenConnector.defaultArguments();
((Connector.IntegerArgument) args.get("timeout")).setValue(ACCEPT_TIMEOUT);
((Connector.IntegerArgument) args.get("timeout")).setValue(ATTACH_TERMINAL_TIMEOUT);
String address = listenConnector.startListening(args);

String[] cmds = LaunchRequestHandler.constructLaunchCommands(launchArguments, false, address);
Expand Down Expand Up @@ -101,6 +105,29 @@ public CompletableFuture<Response> launchInTerminal(LaunchArguments launchArgume
context.setDebugSession(new DebugSession(vm));
logger.info("Launching debuggee in terminal console succeeded.");
resultFuture.complete(response);
} catch (TransportTimeoutException e) {
int commandLength = StringUtils.length(launchArguments.cwd) + 1;
for (String cmd : cmds) {
commandLength += StringUtils.length(cmd) + 1;
}

final int threshold = SystemUtils.IS_OS_WINDOWS ? 8092 : 32 * 1024;
String errorMessage = String.format(launchInTerminalErrorFormat, e.toString());
if (commandLength >= threshold) {
errorMessage = "Failed to launch debuggee in terminal. The possible reason is the command line too long. "
+ "More details: " + e.toString();
logger.severe(errorMessage
+ "\r\n"
+ "The estimated command line length is " + commandLength + ". "
+ "Try to enable shortenCommandLine option in the debug launch configuration.");
}

resultFuture.completeExceptionally(
new DebugException(
errorMessage,
ErrorCode.LAUNCH_IN_TERMINAL_FAILURE.getId()
)
);
} catch (IOException | IllegalConnectorArgumentsException e) {
resultFuture.completeExceptionally(
new DebugException(
Expand Down